Support pruning images using CronJobs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
reviewed
Nov 2, 2017
| containers: | ||
| - name: build-pruner | ||
| image: {{ osbs_prune_image }} | ||
| command: ["/prune.sh"] |
There was a problem hiding this comment.
Can't the default command on the image be used?
There was a problem hiding this comment.
If buildroot is used it cannot be a default command. Instead this should be parametrized, updated the PR
| secretName: {{ osbs_prune_secret }} | ||
| containers: | ||
| - name: build-pruner | ||
| image: {{ osbs_prune_image }} |
There was a problem hiding this comment.
What does this image look like? Will it be maintained by OpenShift via a BuildConfig?
There was a problem hiding this comment.
What does this image look like? Will it be maintained by OpenShift via a BuildConfig?
The most easy way to that is to include necessary utils and scripts in the buildroot. For other instances it could be a separate image with tools only
Signed-off-by: Vadim Rutkovsky <vrutkovs@redhat.com>
twaugh
approved these changes
Nov 2, 2017
lcarva
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadim Rutkovsky vrutkovs@redhat.com