Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cachi2 rubygems / bundler design #565
base: main
Are you sure you want to change the base?
cachi2 rubygems / bundler design #565
Changes from all commits
430f4ad
f57bb26
516c402
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't put everything into the same module - those are the old ways we did implement package managers leading to a single big messy module. We should split the logic into a few self-contained modules wrapped in a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file will be deleted anyway, so I did not bother with splitting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused if these variables are really relevant for the build phase. I was able to successfully build the test repo you set up and the only thing I really needed was to properly set
BUNDLE_CACHE_PATH
.By teading the bundler docs, I got the impression that those variables would be relevant in case we'd use bundler for doing the prefetch, which is not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I will remove
BUNDLE_CACHE_ALL
. Checking the ruby platform is currently done by gemlock-parser. Do we want to set that during the build as well ?