Add support for Go workspaces #999
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoapimentel
force-pushed
the
go-workspaces
branch
2 times, most recently
from
7ac5ce1
to
4fe7c95
Compare
brunoapimentel
force-pushed
the
go-workspaces
branch
from
4fe7c95
to
3acda43
Compare
This commit changes the resolve_gomod function so that it can handle a json stream coming from `go list -m`, which happens when workspaces are used in a Go project. It also removes the previous restrictions on using workspaces. Signed-off-by: Bruno Pimentel <bpimente@redhat.com>
brunoapimentel
force-pushed
the
go-workspaces
branch
from
3acda43
to
63d252b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the resolve_gomod function so that it can handle a json stream coming from
go list -m, which happens when workspaces are used in a Go project.It also removes the previous restrictions on using workspaces.
I still need to add unit/integration tests to cover the new functionality.
Maintainers will complete the following section