Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change travis for working with Fedora 31 #96

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

sergsalatsky
Copy link
Contributor

@sergsalatsky sergsalatsky commented Mar 3, 2020

Maintainers will complete the following section:

  • Commit messages are descriptive enough
  • "Signed-off-by:" line is present in each commit
  • Code coverage from testing does not decrease and new code is covered

test.sh Outdated
for dir in ${EXTRA_MOUNT:-}; do
docker_mounts="${docker_mounts} -v $dir:$dir:z"
engine_mounts="${engine_mounts} -v $dir:$dir:z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an ENGINE env var to set the container engine to be used to run the
test suite. Set podman as the default engine and keep the CI running on
docker.

Signed-off-by: Salatskyi Serhii <ssalatsk@redhat.com>
@sergsalatsky sergsalatsky force-pushed the podman_travis branch 2 times, most recently from c61e355 to 36cd1a2 Compare March 4, 2020 12:05
*OSBS-8649

Deprecated Fedora 29 replaced with CentOS for Bandit
Fedora 31 was added

Signed-off-by: Salatskyi Serhii <ssalatsk@redhat.com>
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also remove EXTRA_MOUNT in another PR

@chmeliik chmeliik merged commit 69191ae into containerbuildsystem:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants