Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test to make sure additional properties are fine #155

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Unit test to make sure additional properties are fine #155

merged 1 commit into from
Dec 19, 2019

Conversation

twaugh
Copy link
Member

@twaugh twaugh commented Dec 19, 2019 •
edited by MartinBasti
Loading

OSBS-8445

Signed-off-by: Tim Waugh twaugh@redhat.com

Maintainers will complete the following section:

  • Commit messages are descriptive enough
  • "Signed-off-by:" line is present in each commit
  • Code coverage from testing does not decrease and new code is covered
  • JSON/YAML configuration changes are updated in the relevant schema
  • Pull request includes link to an osbs-docs PR for user documentation updates

@twaugh
Unit test to make sure additional properties are fine
0ad6e15 
OSBS-8445

Signed-off-by: Tim Waugh <twaugh@redhat.com>
MartinBasti
MartinBasti approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@twaugh twaugh merged commit 0ad6e15 into master Dec 19, 2019
@twaugh twaugh deleted the unit-tests-osbs-8445 branch December 19, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athos-ribeiro athos-ribeiro athos-ribeiro approved these changes

@MartinBasti MartinBasti MartinBasti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twaugh @athos-ribeiro @MartinBasti