upload last osbs-client.log updates #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcerven
changed the title
rcerven
force-pushed
the
upload_logs
branch
2 times, most recently
from
388b507
to
ea82138
Compare
rcerven
changed the title
rcerven
requested review from
ben-alkov,
chmeliik,
lkolacek,
MartinBasti and
mkosiarc
MartinBasti
reviewed
Dec 20, 2021
MartinBasti
reviewed
Dec 20, 2021
MartinBasti
reviewed
Dec 20, 2021
rcerven
force-pushed
the
upload_logs
branch
2 times, most recently
from
9d685d0
to
442cf04
Compare
MartinBasti
reviewed
Dec 20, 2021
tests/test_builder_containerbuild.py
Outdated
| @@ -715,6 +716,7 @@ def test_createSourceContainer_failure_source(self, reason, expected_exc_type): | |||
| if reason == 'signal_cancelled': | |||
| task._incremental_upload_logs = \ | |||
| lambda pid: os.kill(os.getpid(), signal.SIGINT) | |||
| flexmock(task).should_receive('_upload_logs_once').once().and_return(True) | |||
There was a problem hiding this comment.
I'm puzzled here .and_return(True) that function doesn't return anything (i.e. None in py world)
There was a problem hiding this comment.
yeah changed to None, either way it is just to mock that methods to check it was called
when build finishes, we stopped writing and uploading logs, and any other osbs api calls aren't logged anymore, with this change before ending we will also sync logs last time. koji-container build log messages will also now appear in osbs-client logs get_build_error_message is wrapped in try/except in case pipeline run json has again some weird format Signed-off-by: Robert Cerven <rcerven@redhat.com>
MartinBasti
approved these changes
Dec 20, 2021
lkolacek
approved these changes
Dec 20, 2021
|
rn updated: log logger messages in osbs-client log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Cerven rcerven@redhat.com
Maintainers will complete the following section