Process Tekton results instead of labels and annotations #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
CLOUDBLD-8889 OSBS pipelines will provide the most important build results as Tekton results. Fetch repositories and koji_build_id from Tekton results rather than labels and annotations. Previously, koji_build_id was handled as a string (it was taken directly from OpenShift labels without converting to integer). In the results returned by the get_build_results method, koji-build-id is an integer. Convert it to string explicitly to preserve backward compatibility. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
tekton-results
branch
from
6d94798
to
2cab57a
Compare
|
PTAL, depends on containerbuildsystem/osbs-client#1076 but otherwise should be done-ish This will need a docs update, will work on that soon We will also want to follow up on removing the task_annotations_whitelist from atomic-reactor config, I'll either do it now or file a separate story for it |
chmeliik
commented
Feb 22, 2022
| task_annotations = { | ||
| # TODO: previously, remote_sources was double JSON-encoded, do we need to keep that? | ||
| # prev: {"remote_sources": "[{\\"name\\": null, \\"url\\": \\"some url\\"}]"} | ||
| # curr: {"remote_sources": [{"name": null, "url": "some url"}]} |
There was a problem hiding this comment.
How much do we need to worry about keeping build_annotations.json exactly the same as before? I'm thinking not that much, since when we last switched from remote_source_url to remote_sources, nobody seemed to notice
There was a problem hiding this comment.
On the other hand, it's easier to preserve the format than to answer this question. I'll change this to match the previous format
chmeliik
force-pushed
the
tekton-results
branch
from
2cab57a
to
dcbecf1
Compare
CLOUDBLD-8889 Due to unstable behavior of updating annotations on Tekton PipelineRun objects, using build annotations to generate build_annotations.json is not reliable. Instead, generate build_annotations.json from Tekton results. Drop the concept of an annotations whitelist, simply hardcode the list of results to be uploaded. For backward compatibility, keep the build_annotations.json name even though the file now contains Tekton results rather than annotations. The file used to contain raw values of annotations - usually JSON-encoded strings. Encode result values explicitly to preserve the same format. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
tekton-results
branch
from
dcbecf1
to
8d65e41
Compare
|
docs pr: containerbuildsystem/osbs-docs#207 |
ben-alkov
approved these changes
Feb 23, 2022
rcerven
approved these changes
Feb 23, 2022
|
Packit is stuck on Fedora 36, merging anyway |
|
Release notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in individual commits
Maintainers will complete the following section