Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: don't assume default channel #251

Merged

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Oct 7, 2022

Default channel is server configuration, CLI tool shouldn't change it

Signed-off-by: Martin Basti mbasti@redhat.com

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • n/a JSON/YAML configuration changes are updated in the relevant schema
  • n/a Pull request has a link to an osbs-docs PR for user documentation updates

@MartinBasti MartinBasti force-pushed the no_default_channel branch 2 times, most recently from c95e15a to b1ed776 Compare October 7, 2022 12:28
Default channel is server configuration, CLI tool shouldn't change it

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti MartinBasti marked this pull request as ready for review October 7, 2022 12:51
@MartinBasti MartinBasti merged commit 64c0f56 into containerbuildsystem:master Oct 7, 2022
@MartinBasti MartinBasti deleted the no_default_channel branch October 7, 2022 14:13
@MartinBasti
Copy link
Contributor Author

RN

  • CLI uses default channel defined by koji server ('container' channel was hard-coded before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants