Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase writable label in Prepare if not overlaybd #194

Merged
merged 1 commit into from
May 12, 2023

Conversation

HileQAQ
Copy link
Contributor

@HileQAQ HileQAQ commented May 12, 2023

What this PR does / why we need it:
In buildkit build, we will add containerd.io/snapshot/overlaybd.writable=dev when --oci-worker-snapshotter=overlaybd. For compatibility, we should delete this label in Prepare for OCI image, or else it will lead to an error.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Haoqi Miao <miaohaoqi.mhq@alibaba-inc.com>
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
writable label for oci image should be removed

@liulanzheng liulanzheng merged commit 6dff475 into containerd:main May 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants