Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial quota support #14

Closed
wants to merge 1 commit into from
Closed

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

@AkihiroSuda
Copy link
Member Author

temporarily closing, I found QGroupInfo needs to return multiple entries. generally

btrfs.go Outdated
return ioctl(fp.Fd(), C.BTRFS_IOC_QUOTA_CTL, uintptr(unsafe.Pointer(&args)))
}

func QGroupInfo(path string) ([]*QGroupInfoItem, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't need to pointers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stevvooe
Copy link
Member

Is there a way to configure quotas or does this just naturally work?

@AkihiroSuda
Copy link
Member Author

Is there a way to configure quotas or does this just naturally work?

We can implement BTRFS_IOC_QGROUP_LIMIT later, but not needed for containerd, until we support setting quotas in containerd (v1.1? Or should we hurry to implement this in v1.0?)

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@stevvooe
Copy link
Member

stevvooe commented Feb 2, 2018

LGTM

@AkihiroSuda AkihiroSuda closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants