Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cgroup v2 memory implementation #108

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

Zyqsempai
Copy link
Contributor

@Zyqsempai Zyqsempai commented Nov 5, 2019

for #104
Added cgroup v2 memory implementation

Signed-off-by: bpopovschi zyqsempai@mail.ru

@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda @crosbymichael PTAL

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files          23       23           
  Lines        1638     1638           
=======================================
  Hits          744      744           
  Misses        768      768           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff88b8...2843dfa. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one maybe copy/paste error from the CPU impl; otherwise it looks good

v2/memory.go Outdated Show resolved Hide resolved
@Zyqsempai Zyqsempai force-pushed the 104-added-memory-cgroup2-impl branch from 75d7428 to 2843dfa Compare November 5, 2019 16:02
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
Copy link
Contributor Author

@estesp Fixed.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 010a0d6 into containerd:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants