Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 io support #112

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Add v2 io support #112

merged 2 commits into from
Nov 8, 2019

Conversation

crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
func (c *Manager) Stat() (map[string]uint64, error) {
var singleValueFiles = []string{
"pids.current",
"pids.max",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be another PR, but we need memory.current and memory.swap.current?
https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html

@crosbymichael
Copy link
Member Author

@Zyqsempai this has the code for how we will handle stats

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4baafdb into containerd:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants