-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OOM notification for Memory controller #115
Added OOM notification for Memory controller #115
Conversation
Does kernel have this feature? Seems not https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html |
@AkihiroSuda Do we actually care about other events here? Coz we can easily filter it only by |
Yes, but I agree it is not now |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
- Coverage 36.34% 35.75% -0.6%
=========================================
Files 32 32
Lines 2102 2137 +35
=========================================
Hits 764 764
- Misses 1210 1245 +35
Partials 128 128
Continue to review full report at Codecov.
|
@AkihiroSuda You mean something like this? PTAL |
@crosbymichael PTAL |
rebase please :) |
254a491
to
d03d516
Compare
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@crosbymichael Done. |
LGTM |
Partially Fixes #104
@crosbymichael @AkihiroSuda
So this Pr is on of the ideas I have on how we can implement
OOM notifications
incGroupv2
.So, I see here at least two directions, we can implement
Inotify fd
check right here and in case if we receiveinotify
event, create new separate file foroom's
only, and return that filefd
.On other hand we can delegate it to next layers(containerd etc.)
What do you think of this approach?
Signed-off-by: bpopovschi zyqsempai@mail.ru