Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RDMA controller #119

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

Zyqsempai
Copy link
Contributor

@Zyqsempai Zyqsempai commented Nov 15, 2019

Related to #104

Added RDMA controller

Signed-off-by: bpopovschi zyqsempai@mail.ru

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.89%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #119     +/-   ##
=========================================
- Coverage   35.46%   34.57%   -0.9%     
=========================================
  Files          32       33      +1     
  Lines        2154     2210     +56     
=========================================
  Hits          764      764             
- Misses       1262     1318     +56     
  Partials      128      128
Impacted Files Coverage Δ
v2/rdma.go 0% <0%> (ø)
v2/utils.go 6.97% <0%> (-2.4%) ⬇️
v2/manager.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf5261...3053714. Read the comment docs.

@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda @crosbymichael PTAL

@crosbymichael
Copy link
Member

will need a rebase after all the previous merges

Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
Copy link
Contributor Author

@crosbymichael Done

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b01be99 into containerd:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants