Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: toggle ancestors of c.path, not c.path itself #124

Merged
merged 2 commits into from
Nov 18, 2019
Merged

v2: toggle ancestors of c.path, not c.path itself #124

merged 2 commits into from
Nov 18, 2019

Conversation

AkihiroSuda
Copy link
Member

Fix #121

@codecov-io
Copy link

codecov-io commented Nov 15, 2019 •
edited
Loading

Codecov Report

Merging #124 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   35.44%   35.35%   -0.09%     
==========================================
  Files          35       35              
  Lines        2370     2376       +6     
==========================================
  Hits          840      840              
- Misses       1397     1403       +6     
  Partials      133      133
Impacted Files Coverage Δ
v2/manager.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8ad43...3022591. Read the comment docs.

@AkihiroSuda AkihiroSuda mentioned this pull request Nov 15, 2019
Closed
14 tasks
@crosbymichael
Copy link
Member

LGTM

@AkihiroSuda
v2: refactor ListControllers
079295c 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
v2: toggle ancestors of c.path, not c.path itself
3022591 
Fix containerd#121

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

rebased

estesp
estesp approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit bd09c0d into containerd:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: ToggleControllers() should toggle ancestors of c.path, not c.path itself
4 participants
@AkihiroSuda @codecov-io @crosbymichael @estesp