Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added systemd manager #125

Merged
merged 7 commits into from
Jan 7, 2020
Merged

Added systemd manager #125

merged 7 commits into from
Jan 7, 2020

Conversation

Zyqsempai
Copy link
Contributor

Added NewSystemd and LoadSystemd.
@AkihiroSuda @crosbymichael I am stuck a little bit here, please guide me in right direction;)
Signed-off-by: bpopovschi zyqsempai@mail.ru

AkihiroSuda
AkihiroSuda reviewed Nov 18, 2019
View reviewed changes
v2/systemd.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Nov 18, 2019
View reviewed changes
v2/systemd.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #125 into master will decrease coverage by 0.8%.
The diff coverage is 12.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   34.79%   33.98%   -0.81%     
==========================================
  Files          35       35              
  Lines        2463     2557      +94     
==========================================
+ Hits          857      869      +12     
- Misses       1469     1551      +82     
  Partials      137      137
Impacted Files Coverage Δ
v2/manager.go 0% <0%> (ø) ⬆️
v2/utils.go 10.85% <0%> (-0.36%) ⬇️
v2/cpu.go 43.58% <100%> (+25.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e077fb6...acbc802. Read the comment docs.

AkihiroSuda
AkihiroSuda reviewed Nov 18, 2019
View reviewed changes
v2/systemd.go Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 19, 2019
Closed
14 tasks
@Zyqsempai
Copy link
Contributor Author

Now when I am looking at the code, I am thinking maybe it's make more sense to add systemd management to the main manager?

@Zyqsempai
Copy link
Contributor Author

Reworked it a little bit @AkihiroSuda PTAL

@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda Let's finish this one, PTAL

@AkihiroSuda
Copy link
Member

can we have cgctl?

@Zyqsempai
Copy link
Contributor Author

sure

@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda PTAL

AkihiroSuda
AkihiroSuda reviewed Dec 10, 2019
View reviewed changes
v2/manager.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Dec 10, 2019
View reviewed changes
v2/utils.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Dec 10, 2019
View reviewed changes
v2/utils.go Outdated Show resolved Hide resolved
@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Dec 11, 2019 •
edited
Loading

@AkihiroSuda Done

@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda ping

@AkihiroSuda
Copy link
Member

How to test this with cgctl?

@Zyqsempai Zyqsempai force-pushed the 104-add-systemd branch 2 times, most recently from 0d07640 to d94af43 Compare December 24, 2019 12:29
@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda @crosbymichael Soo, finally it look like something not so bad))
Please review it.
I added few tests for systemd in cpu and memory tests.
Also you can test it with cgctl by make cgutil systemd test-sg.scope $pid specify $pid you want to attach.

@AkihiroSuda
Copy link
Member

Thanks, but Im on vacation without laptop. Will look into next year.

@Zyqsempai
Copy link
Contributor Author

Have a nice holidays then;)

@Zyqsempai
Copy link
Contributor Author

It's time to get back to work on this one;)

AkihiroSuda
AkihiroSuda approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Zyqsempai
Added systemd manager
5efa14e 
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
Systemd refactoring
3a32c65 
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
conflict fix
b0a15b1 
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
Toggle controllers fix
7b4fbc7 
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
@Zyqsempai
tests for systemd controllers
fe68974 
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
@Zyqsempai
Resource rework + path fix
7d585c4 
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
@Zyqsempai
rebase on master
acbc802 
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
@Zyqsempai
Copy link
Contributor Author

@crosbymichael @estesp PTAL, to merge this one finally;)

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit d1b3bdc into containerd:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zyqsempai @codecov-io @AkihiroSuda @crosbymichael