memory.events handling rework #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
AkihiroSuda
reviewed
Feb 6, 2020
| @@ -526,20 +526,19 @@ func (c *Manager) freeze(path string, state State) error { | |||
| } | |||
| } | |||
|
|
|||
| func (c *Manager) MemoryEventFD() (uintptr, error) { | |||
| func (c *Manager) MemoryEventFD() (int, uint32, error) { | |||
There was a problem hiding this comment.
(int, uint32
why different types?
There was a problem hiding this comment.
Coz this is the base types for file descriptor and watch descriptor, at least syscall.InotifyRmWatch() expects it in that way.
AkihiroSuda
reviewed
Feb 6, 2020
|
@AkihiroSuda Added goDoc and updated PR description, related to "how to test it" i tried to add test but I wasn't able to properly simulate OOM behavior for process in the test. |
|
@AkihiroSuda Can we move forward this one, coz implementation of the OOM handler in containerD main repo depends on this one. |
|
@fuweid PTAL? |
AkihiroSuda
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small rework of the memory.events handler in order to implement OOM handler in main containerD repo.
During the memory.events handler implementations, were made few mistakes, this PR fixes them.
Signed-off-by: Boris Popovschi zyqsempai@mail.ru