make cmd/ a separate module (as it's only for testing) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To my knowledge, the `cmd/cgctl` utility is only for testing, and its dependencies should therefore not be needed as dependencies for the main module. This patch adds a `go.mod` in the `cmd/` directory to make it it's own module. A replace rule is included in that `go.mod` to make it use the local version of github.com/containerd/cgroups when building. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my knowledge, the
cmd/cgctlutility is only for testing (also see 7bf30d7), and its dependencies should therefore not be needed as dependencies for the main module.This patch adds a
go.modin thecmd/directory to make it it's own module. A replace rule is included in thatgo.modto make it use the local version of github.com/containerd/cgroups when building.