Add support for rdma cgroup #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, From the Travis-CI config it seems that it checkout the older version of runc-spec in below command. git checkout 96de01bbb42c7af89bff100e10a9f0fb62e75bfb runc-spec is updated last week for inclusion of rdma cgroup. |
|
@paravmellanox just change the runtime commit here: https://github.com/containerd/cgroups/blob/master/.travis.yml#L7 |
RDMA controller/cgroup support is added with Linux kernel 4.11. It allows to limit RDMA/IB specific resources. It is described at [1]. Add support to set rdma cgroup parameters and read statistics. [1] https://www.kernel.org/doc/Documentation/cgroup-v1/rdma.txt Signed-off-by: Parav Pandit <parav@mellanox.com>
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 13.95% 13.12% -0.83%
==========================================
Files 22 23 +1
Lines 4106 4494 +388
==========================================
+ Hits 573 590 +17
- Misses 3423 3792 +369
- Partials 110 112 +2
Continue to review full report at Codecov.
|
|
LGTM |
|
thanks @estesp, @crosbymichael. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDMA controller/cgroup support is added with Linux kernel 4.11.
It allows to limit RDMA/IB specific resources.
It is described at [1].
runc-spec update is already merged last week in PR [2].
Add support to set rdma cgroup parameters and read statistics.
[1] https://www.kernel.org/doc/Documentation/cgroup-v1/rdma.txt
[2] opencontainers/runtime-spec#942
Signed-off-by: Parav Pandit parav@mellanox.com