Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update method for the cpuset controller #45

Merged
merged 1 commit into from Apr 4, 2018

Conversation

anastop
Copy link
Contributor

@anastop anastop commented Mar 23, 2018

So that the CPUs and memory nodes of a cgroup can be dynamically changed.

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #45 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   13.12%   13.12%   -0.01%     
==========================================
  Files          23       23              
  Lines        4494     4496       +2     
==========================================
  Hits          590      590              
- Misses       3792     3794       +2     
  Partials      112      112
Impacted Files Coverage Δ
cpuset.go 41.97% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c755602...15ef4c3. Read the comment docs.

@crosbymichael
Copy link
Member

Have you tried this out to see if it works or if there were any side effects?

@anastop
Copy link
Contributor Author

anastop commented Mar 24, 2018

I have tried this in my case (dynamic process CPU rescheduling) and it works as expected, that is, processes migrate to the new cpuset's CPUs. Unfortunately, my test environment (single-NUMA node) does not allow me to test cpuset.mems. Other than this, are there particular test cases I could run to see possible side effects?

@crosbymichael
Copy link
Member

@anastop can you sign your commit with the DCO ?

So that the CPUs and memory nodes of a cgroup can be dynamically changed.

Signed-off-by: Nikos Anastopoulos <n.anastop@gmail.com>
@anastop
Copy link
Contributor Author

anastop commented Apr 4, 2018

should be ok now

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 07683a6 into containerd:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants