-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove call to unitName #52
Conversation
ghost
commented
Aug 16, 2018
- Calling unitName incorrectly appends -slice onto the end of the slice cgroup we are looking for
- Tested and can't see any obvious side effects by removing this call
- Fixes cgroups: cgroup deleted #47
Tested this and it works as expected. My test code worked as follows:
|
Can you sign your commit with the DCO? https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work Thanks for working on this! |
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 13.32% 13.32%
=======================================
Files 23 23
Lines 4518 4518
=======================================
Hits 602 602
Misses 3800 3800
Partials 116 116
Continue to review full report at Codecov.
|
@crosbymichael Think I have done this - although I ended up with 3 commits for 1 tiny change :( |
@Sykomaniac if you amend and force push it should be one. you can git rebase -i HEAD~3 and squash |
- Calling unitName incorrectly appends -slice onto the end of the slice cgroup we are looking for - Tested and can'r see any obvious side effects by removing this call Signed-off-by: Ashley Sykes ashleysykes01@gmail.com
@crosbymichael Force push done - now only one commit |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM