-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project references and use common project travis #57
Conversation
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 13.29% 13.29%
=======================================
Files 23 23
Lines 4528 4528
=======================================
Hits 602 602
Misses 3810 3810
Partials 116 116 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments..
.travis.yml
Outdated
@@ -8,8 +8,16 @@ install: | |||
- cd $GOPATH/src/github.com/opencontainers && git clone https://github.com/opencontainers/runtime-spec && cd runtime-spec && git checkout fa4b36aa9c99e00c2ef7b5c0013c84100ede5f4e | |||
- cd $GOPATH/src/github.com/containerd/cgroups | |||
- go get -t ./... | |||
- go get -u github.com/vbatts/git-validation | |||
- go get -u github.com/kunalkushwaha/ltag | |||
- go get -u github.com/LK4D4/vndr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used..
README.md
Outdated
* [Maintainers](https://github.com/containerd/project/blob/master/MAINTAINERS), | ||
* and [Contributing guidelines](https://github.com/containerd/project/blob/master/CONTRIBUTING.md) | ||
|
||
in our `containerd/project` repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/s/in/information in/
Add in DCO check and file header check; add project boilerplate to README with governance, maintainers, and contributing guidelines. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
e08013c
to
e4cf832
Compare
@mikebrow updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Add in DCO check and file header check; add project boilerplate to
README with governance, maintainers, and contributing guidelines.
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com