-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blkio weight/leafWeight pointer value #69
Conversation
1925066
to
be7c666
Compare
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 14.3% 14.27% -0.03%
==========================================
Files 23 23
Lines 4579 4588 +9
==========================================
Hits 655 655
- Misses 3803 3812 +9
Partials 121 121
Continue to review full report at Codecov.
|
@cclerget i'd make https://github.com/containerd/cgroups/pull/69/files#diff-a0138ebe17a246a844ed97a795eecd9eR194 and https://github.com/containerd/cgroups/pull/69/files#diff-a0138ebe17a246a844ed97a795eecd9eR206 conditional. Don't place them in the slice if they have |
@crosbymichael Sorry about confusion, updated with your suggestions |
Looks great @cclerget ! maybe a simple test to make sure this does not panic anymore would be amazing. |
And can you squash your commits into one before we merge? |
Signed-off-by: Cedric Clerget <cedric.clerget@gmail.com>
a48fed3
to
64bade4
Compare
Yep, I successfully run same tests (from opencontainers/runtime-tools validation tests) without panic |
LGTM |
1 similar comment
LGTM |
Prevent weight/leafweight from returning address value instead :
Not sure if this is the right thing to do by returning "1000" when pointer is null ...