GHA: update to Go 1.16.x, actions/setup-go@v2, fix badges #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
requested changes
Mar 16, 2021
|
@dmcgowan updated; PTAL |
dmcgowan
reviewed
Mar 16, 2021
| @@ -1,6 +1,8 @@ | |||
| # console | |||
|
|
|||
| [](https://travis-ci.org/containerd/console) | |||
| [](https://pkg.go.dev/github.com/containerd/console) | |||
| [](https://github.com/containerd/console/actions?query=workflow%3ACI) | |||
There was a problem hiding this comment.
The workflow name for this project is Go, not CI. Not sure why that is, either CI needs to be changed here or rename in ci.yml to CI. This produces 404
There was a problem hiding this comment.
I updated ci.yml and renamed to CI, which is what we use in the other repositories.
There's probably some simplification possible in GHA (swap some steps out for containerd/project-checks@v1), but I'll look at those in follow ups across the board (it's not really urgent)
This was overlooked when switching to GHA. Also adds badges for go.pkg.dev and Go Report Card. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked when switching to GHA. Also adds badges for go.pkg.dev and Go Report Card.