Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove solaris implementation #62

Merged
merged 1 commit into from Mar 21, 2022
Merged

remove solaris implementation #62

merged 1 commit into from Mar 21, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 11, 2022

The solaris implementation is not used anywhere, and removed from most projects, so we may as well clean up the corresponding files here.

The solaris implementation is not used anywhere, and removed from most
projects, so we may as well clean up the corresponding files here.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

^^ at least, I don't think we take solaris into account anymore in any of our other repositories; happy to close this one if there's concerns about this (or if we know there's actually still active development happening in this area).

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agree unless someone knows otherwise--seems solaris has been dropped from all the major container building blocks

@dmcgowan dmcgowan added this to New in Code Review via automation Feb 16, 2022
@dmcgowan dmcgowan moved this from New to Ready For Review in Code Review Feb 16, 2022
@mxpv mxpv merged commit 21ccd90 into containerd:main Mar 21, 2022
Code Review automation moved this from Ready For Review to Done Mar 21, 2022
@thaJeztah thaJeztah deleted the sunset branch March 21, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants