Skip to content

Commit

Permalink
Merge pull request #1241 from stevvooe/allow-resumable-upload
Browse files Browse the repository at this point in the history
metadata: defer ingest lock to backend
  • Loading branch information
stevvooe committed Jul 24, 2017
2 parents bfe747d + d0e396a commit a9ab45f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion content/local/store.go
Expand Up @@ -271,7 +271,7 @@ func (s *store) Writer(ctx context.Context, ref string, total int64, expected di
path, refp, data := s.ingestPaths(ref)

if err := tryLock(ref); err != nil {
return nil, errors.Wrapf(err, "locking %v failed", ref)
return nil, errors.Wrapf(err, "locking ref %v failed", ref)
}

var (
Expand Down
25 changes: 15 additions & 10 deletions metadata/content.go
Expand Up @@ -303,18 +303,23 @@ func (cs *contentStore) Writer(ctx context.Context, ref string, size int64, expe
return err
}

if len(bkt.Get([]byte(ref))) > 0 {
return errors.Wrapf(errdefs.ErrUnavailable, "ref %v is currently in use", ref)
}
var (
bref string
brefb = bkt.Get([]byte(ref))
)

sid, err := bkt.NextSequence()
if err != nil {
return err
}
if brefb == nil {
sid, err := bkt.NextSequence()
if err != nil {
return err
}

bref := createKey(sid, ns, ref)
if err := bkt.Put([]byte(ref), []byte(bref)); err != nil {
return err
bref = createKey(sid, ns, ref)
if err := bkt.Put([]byte(ref), []byte(bref)); err != nil {
return err
}
} else {
bref = string(brefb)
}

// Do not use the passed in expected value here since it was
Expand Down

0 comments on commit a9ab45f

Please sign in to comment.