Skip to content

Commit

Permalink
Merge pull request #1211 from Random-Liu/add-max-concurrency-support
Browse files Browse the repository at this point in the history
Add max concurrent downloads support.
  • Loading branch information
Random-Liu committed Jul 29, 2019
2 parents 994cea8 + c78caf9 commit f0a677e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions docs/config.md
Expand Up @@ -76,6 +76,9 @@ version = 2
# This is useful when the containerd does not have permission to decrease OOMScoreAdj.
restrict_oom_score_adj = false

# max_concurrent_downloads restricts the number of concurrent downloads for each image.
max_concurrent_downloads = 3

# 'plugins."io.containerd.grpc.v1.cri".containerd' contains config related to containerd
[plugins."io.containerd.grpc.v1.cri".containerd]

Expand Down
3 changes: 3 additions & 0 deletions pkg/config/config.go
Expand Up @@ -177,6 +177,8 @@ type PluginConfig struct {
// current OOMScoreADj.
// This is useful when the containerd does not have permission to decrease OOMScoreAdj.
RestrictOOMScoreAdj bool `toml:"restrict_oom_score_adj" json:"restrictOOMScoreAdj"`
// MaxConcurrentDownloads restricts the number of concurrent downloads for each image.
MaxConcurrentDownloads int `toml:"max_concurrent_downloads" json:"maxConcurrentDownloads"`
}

// X509KeyPairStreaming contains the x509 configuration for streaming
Expand Down Expand Up @@ -242,6 +244,7 @@ func DefaultConfig() PluginConfig {
},
},
},
MaxConcurrentDownloads: 3,
}
}

Expand Down
1 change: 1 addition & 0 deletions pkg/server/image_pull.go
Expand Up @@ -108,6 +108,7 @@ func (c *criService) PullImage(ctx context.Context, r *runtime.PullImageRequest)
containerd.WithPullSnapshotter(c.config.ContainerdConfig.Snapshotter),
containerd.WithPullUnpack,
containerd.WithPullLabel(imageLabelKey, imageLabelValue),
containerd.WithMaxConcurrentDownloads(c.config.MaxConcurrentDownloads),
)
if err != nil {
return nil, errors.Wrapf(err, "failed to pull and unpack image %q", ref)
Expand Down

0 comments on commit f0a677e

Please sign in to comment.