Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify image components are "ready"/available for use #1514

Closed
estesp opened this issue Sep 14, 2017 · 4 comments
Closed

Verify image components are "ready"/available for use #1514

estesp opened this issue Sep 14, 2017 · 4 comments
Milestone

Comments

@estesp
Copy link
Member

estesp commented Sep 14, 2017

Per conversation at MobySummit with @stevvooe @Random-Liu :

Need an "ensure" or "verify" function in the client library to properly walk an image's components to verify all pulled/unpacked and in a "ready" state to be used, e.g., for a container start referenced against that image ref. Without this, it is possible today to rely on an image whose reference is in the content store but whose components may or may not be ready/fully unpacked.

@crosbymichael
Copy link
Member

@estesp did #1567 resolve this issue?

@estesp
Copy link
Member Author

estesp commented Oct 25, 2017

Let's just verify with @Random-Liu, but it was definitely meant to. I just didn't follow whether the commentary between @stevvooe and Lantau was incorporated into that PR or whether there was anything else outside of cri-containerd to add.

@crosbymichael
Copy link
Member

@Random-Liu can you verify if this issue is resolved or if there are still aspects that need to be address?

@Random-Liu
Copy link
Member

Random-Liu commented Nov 20, 2017

@estesp @crosbymichael We've added this.

Besides checking image readiness across cri-containerd restart, we also use IsUnpacked to check whether an image is unpacked, and unpack it again if not before creating each container:

mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this issue Nov 13, 2020
…9.0-beta.2

Update kubernetes to 1.19.0 beta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants