Consider switching from gometalinter to golangci-lint

[ehotinger]

Not a big deal for this project right now, but I hit a few oddities with Go 1.12 in other projects and had to dig into linter issues. Seems like gometalinter is EOL soon.

The gometalinter GitHub project will be archived on 2019-04-07. Releases will still be available for download but no further code will be committed and issues will be read-only.

Switch to golangci-lint.

Many thanks to all contributors, in particular dnephin who has helped me maintain gometalinter for the last year or two.

See also: alecthomas/gometalinter#590

[estesp]

Thanks for the pointer. Definitely something we can look into.

[ehotinger]

I have https://github.com/ehotinger/containerd/commit/db1288fc54c5b60793fb89ed8ee4fd0fb1946fcb laying around to fix a few tooling issues after updates for myself. I can PR it if people care about it in the master branch. There's one minor issue with ctr's usage of the progress bar which I made an upstream issue for; didn't bother tracking it down yet.

[ehotinger]

Update: golangci/golangci-lint#414 was fixed so containerd can be switched without any other issues.

[crosbymichael]

Go ahead and submit a PR for this

[ehotinger]

@crosbymichael go vet errors on master:

runtime/v1/linux/proc/io.go:266:2: lostcancel: the cancel function is not used on all paths (possible context leak) (govet)
        ctx, cancel := context.WithCancel(ctx)
        ^
runtime/v1/linux/proc/io.go:274:3: lostcancel: this return statement may be reached without using the cancel var defined on line 266 (govet)
                return nil, err

Want to ignore this rule?