Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from gometalinter to golangci-lint #3411

Merged
merged 2 commits into from Jul 15, 2019
Merged

Switch from gometalinter to golangci-lint #3411

merged 2 commits into from Jul 15, 2019

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented Jul 15, 2019

Closes #3410
Closes #3060

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 15, 2019

Build succeeded.

@mxpv mxpv force-pushed the linter branch 2 times, most recently from eeec3f1 to cafbd05 Compare July 15, 2019 03:23
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 15, 2019

Build succeeded.

mxpv added 2 commits July 14, 2019 20:49
@mxpv
Switch to golangci-lint
2b521e2 
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
@mxpv
Fix linter errors
ef7f46e 
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 15, 2019

Build succeeded.

@codecov-io
Copy link

codecov-io commented Jul 15, 2019 •
edited

Codecov Report

Merging #3411 into master will decrease coverage by 8.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3411      +/-   ##
==========================================
- Coverage   48.98%   40.27%   -8.72%     
==========================================
  Files         102       76      -26     
  Lines        9903    10496     +593     
==========================================
- Hits         4851     4227     -624     
- Misses       4207     5685    +1478     
+ Partials      845      584     -261
Flag Coverage Δ
#linux ?
#windows 40.27% <ø> (?)
Impacted Files Coverage Δ
cio/io.go 1.4% <0%> (-53.6%) ⬇️
snapshots/native/native.go 1.79% <0%> (-51.25%) ⬇️
archive/tar.go 16.99% <0%> (-33.86%) ⬇️
metadata/snapshot.go 24.02% <0%> (-31.76%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.69% <0%> (-6.51%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b6c31...ef7f46e. Read the comment docs.

fuweid
fuweid reviewed Jul 15, 2019
View reviewed changes
cmd/ctr/commands/events/events.go
@@ -47,7 +47,7 @@ var Command = cli.Command{
var e *events.Envelope
select {
case e = <-eventsCh:
case err, open = <-errCh:
case err = <-errCh:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that we can remove the open var here because open always is true

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit f3e148b into containerd:master Jul 15, 2019
@mxpv mxpv deleted the linter branch July 15, 2019 16:54
@thaJeztah thaJeztah mentioned this pull request Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make check failed in mac OS X Consider switching from gometalinter to golangci-lint
5 participants
@mxpv @codecov-io @crosbymichael @AkihiroSuda @fuweid