Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinned is still false after ctr label image io.cri-containerd.pinned=pinned #9328

Closed
yuqitao opened this issue Nov 3, 2023 · 3 comments · Fixed by #9338
Closed

pinned is still false after ctr label image io.cri-containerd.pinned=pinned #9328

yuqitao opened this issue Nov 3, 2023 · 3 comments · Fixed by #9338
Assignees
Labels

Comments

@yuqitao
Copy link

yuqitao commented Nov 3, 2023

Description

I want pin an image which I have imported, so I use ctr -n k8s.io images label imageName io.cri-containerd.pinned=pinned.
But crictl inspecti imageName still return pinned=false.

CRIService get ImageUpdate event,the image in store does not been updated because these logic:

if oldID == img.ID {

Steps to reproduce the issue

  1. ctr -n k8s.io images label docker.io/library/redis:2.8.23 io.cri-containerd.pinned=pinned
  2. crictl inspecti docker.io/library/redis:2.8.23

Describe the results you received and expected

crictl inspecti imageName still return pinned=true

What version of containerd are you using?

v1.7.8

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

No response

@yuqitao
Copy link
Author

yuqitao commented Nov 3, 2023

I see: #8867; but it seems like this pr does not work.

@yuqitao
Copy link
Author

yuqitao commented Nov 3, 2023

@Iceber PTAL

@Iceber Iceber self-assigned this Nov 3, 2023
@Iceber
Copy link
Member

Iceber commented Nov 5, 2023

#8867 only fixes the pinned issue on pull, but it really doesn't fix the updating of the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants