Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri: fix update of pinned label for images #9338

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Nov 5, 2023

fix: #9328

A image is pinned when any of its references has the pinned label.

When none of the references to a image have the pinned label, the image is not pinned.

@Iceber Iceber force-pushed the update_pinned_label branch 2 times, most recently from 8639d73 to eb57d70 Compare November 5, 2023 09:29
@fuweid fuweid marked this pull request as draft November 5, 2023 10:05
@fuweid fuweid changed the title [WIP] cri: fix update of pinned label for images cri: fix update of pinned label for images Nov 5, 2023
@Iceber Iceber force-pushed the update_pinned_label branch 10 times, most recently from 27a815d to c6075af Compare November 10, 2023 15:23
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
@Iceber Iceber marked this pull request as ready for review November 10, 2023 15:28
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp added this pull request to the merge queue Nov 16, 2023
Merged via the queue into containerd:main with commit 1a54a21 Nov 16, 2023
40 checks passed
@samuelkarp samuelkarp added cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 16, 2023
@samuelkarp samuelkarp removed the cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch label Dec 1, 2023
@samuelkarp samuelkarp added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinned is still false after ctr label image io.cri-containerd.pinned=pinned
4 participants