Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] Use LOOP_CONFIGURE when creating loop devices #10209

Merged
merged 3 commits into from May 16, 2024
Merged

[release/1.7] Use LOOP_CONFIGURE when creating loop devices #10209

merged 3 commits into from May 16, 2024

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented May 10, 2024 •
edited

Issue

Optimization for creating loop devices on kernels >= 5.8 would be nice to have in release/1.7.

Description

This change backports #9211 and follow on changes #9805, #9813 to release/1.7.

Signed-off-by: Austin Vazquez macedonv@amazon.com

@k8s-ci-robot
Copy link

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez force-pushed the cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7 branch from 44c621a to cbc37f5 Compare May 10, 2024 19:36
@austinvazquez
Copy link
Contributor Author

It would be nice to have #10204 first which vendors golang.org/x/sys@v0.16.0 to match the base of the cherry-picked commit but not a hard requirement.

@austinvazquez austinvazquez marked this pull request as ready for review May 10, 2024 20:33
@austinvazquez austinvazquez force-pushed the cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7 branch from cbc37f5 to c8e8844 Compare May 13, 2024 13:27
@alex-matei @austinvazquez
Use LOOP_CONFIGURE when creating loop devices
a0739dc 
LOOP_CONFIGURE is a new ioctl that is a lot faster than
the LOOP_SET_FD+LOOP_SET_STATUS64 calls

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
(cherry picked from commit a782fd6)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@alex-matei @austinvazquez
Swap internal ioctl implementation with golang.org/x/sys
7bd3be9 
Replace internal LOOP_CONFIGURE ioctl implementation with
IoctlLoopConfigure from sys

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
(cherry picked from commit c2dfae8)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@alex-matei @austinvazquez
Remove internal LoopConfig struct
803aaa6 
The struct is now part of golang.org/x/sys.
Follow-up for containerd#9805

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
(cherry picked from commit ccec1e6)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez force-pushed the cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7 branch from c8e8844 to 803aaa6 Compare May 13, 2024 15:22
@austinvazquez
Copy link
Contributor Author

Rebased.

kzys
kzys approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@dmcgowan dmcgowan merged commit 2441c2d into containerd:release/1.7 May 16, 2024
56 checks passed
@dmcgowan dmcgowan mentioned this pull request May 16, 2024
Merged
@austinvazquez austinvazquez deleted the cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7 branch May 16, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
impact/changelog ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@austinvazquez @k8s-ci-robot @kzys @dmcgowan @alex-matei