fix(metrics): correct image pull throughput calculation

[azr]

Hello there,

If I'm correct, image.Size() returns an addition of blob sizes that are already in bytes, so the division is not needed here.

containerd/client/image.go

Lines 176 to 178 in 504bd15

	func (i *image) Size(ctx context.Context) (int64, error) {
	return usage.CalculateImageUsage(ctx, i.i, i.client.ContentStore(), usage.WithManifestLimit(i.platform, 1), usage.WithManifestUsage())
	}

containerd/core/images/usage/calculator.go

Line 142 in 504bd15

usage += u.Size

containerd/core/snapshots/snapshotter.go

Line 175 in 504bd15

Size int64 // provides usage, in bytes, of snapshot

[k8s-ci-robot]

Hi @azr. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ktock]

Assumed to be MB

containerd/internal/cri/server/images/metrics.go

Lines 27 to 28 in 45e3091

	// image size in MB / image pull duration in seconds
	imagePullThroughput prom.Histogram

// image size in MB / image pull duration in seconds

[azr]

ah, good catch, closing !