Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] Explicitly set release latest to false #10263

Conversation

austinvazquez
Copy link
Contributor

Issue

Partial #10262

Description

This change disables marking of containerd 1.6 releases as latest. This change backports 21d3fed which updates the action-gh-release package from v1 to v2 which adds the make_latest functionality required by the change.

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 21d3fed)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@k8s-ci-robot
Copy link

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This change explicitly sets mainline releases as not latest.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
(cherry picked from commit 2d73340)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez force-pushed the disable-make-latest-in-release-1.6 branch from e3ff112 to 5eaf5f8 Compare May 25, 2024 15:30
@austinvazquez austinvazquez changed the title [release/1.6] Disable make latest in release 1.6 [release/1.6] Explicitly set release latest to false May 25, 2024
@austinvazquez austinvazquez marked this pull request as ready for review May 25, 2024 15:35
@thaJeztah
Copy link
Member

/ok-to-test

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit d55b748 into containerd:release/1.6 May 25, 2024
48 checks passed
@austinvazquez austinvazquez deleted the disable-make-latest-in-release-1.6 branch May 25, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants