[release/1.6] Migrate errdefs package to github.com/containerd/errdefs
#10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the errdefs package to be an alias for the new errdefs module. This helps transitioning consumers to the new module, and makes sure that containerd v2 and v1 use the same definitions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
akhilerm
reviewed
May 27, 2024
akhilerm
approved these changes
May 27, 2024
|
It's to make sure projects using containerd as a module don't break; the aliases will make sure that they use the same type(s) as containerd is using, which come from the new errdefs module. Eventually all uses should go away, but at least currently there's still uses, including some in containerd's dependency tree; Same was done for the We can't update those yet, until this change is in, and released, otherwise they would be using a different type than containerd itself (so errors wouldn't be matched), but once this is released, we can update the minimum required version of containerd in those repositories, and switch to using the other module. |
estesp
approved these changes
May 28, 2024
dmcgowan
changed the title
dmcgowan
changed the title
errdefs package to github.com/containerd/errdefs
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/containerd/errdefs#10266This updates the errdefs package to be an alias for the new errdefs module. This helps transitioning consumers to the new module, and makes sure that containerd v2 and v1 use the same definitions.