Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api minimum Go version to 1.21 #10276

Merged
merged 1 commit into from
May 29, 2024

Conversation

dmcgowan
Copy link
Member

A higher go build version is not required for the API and this will help some downstream projects test the change which are currently blocked on 1.22 upgrade.

A higher go build version is not required for the API

Signed-off-by: Derek McGowan <derek@mcg.dev>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah
Copy link
Member

So, it does not immediately refuse it now, but it looks like API 1.8 is not backward compatible from a Go perspective. It looks like some parts were removed that the 1.7 code expects (perhaps moved elsewhere?)

24.59 # github.com/containerd/containerd/services/introspection
24.59 vendor/github.com/containerd/containerd/services/introspection/local.go:88:35: cannot convert &Local{} (value of type *Local) to type "github.com/containerd/containerd/api/services/introspection/v1".IntrospectionClient: *Local does not implement "github.com/containerd/containerd/api/services/introspection/v1".IntrospectionClient (missing method PluginInfo)
24.59 vendor/github.com/containerd/containerd/services/introspection/service.go:57:12: cannot use localClient (variable of type *Local) as "github.com/containerd/containerd/api/services/introspection/v1".IntrospectionClient value in struct literal: *Local does not implement "github.com/containerd/containerd/api/services/introspection/v1".IntrospectionClient (missing method PluginInfo)
24.85 # github.com/containerd/containerd/sandbox
24.85 vendor/github.com/containerd/containerd/sandbox/bridge.go:35:10: cannot use &grpcBridge{…} (value of type *grpcBridge) as "github.com/containerd/containerd/api/runtime/sandbox/v1".TTRPCSandboxService value in return statement: *grpcBridge does not implement "github.com/containerd/containerd/api/runtime/sandbox/v1".TTRPCSandboxService (missing method SandboxMetrics)
24.85 vendor/github.com/containerd/containerd/sandbox/bridge.go:45:33: cannot use (*grpcBridge)(nil) (value of type *grpcBridge) as "github.com/containerd/containerd/api/runtime/sandbox/v1".TTRPCSandboxService value in variable declaration: *grpcBridge does not implement "github.com/containerd/containerd/api/runtime/sandbox/v1".TTRPCSandboxService (missing method SandboxMetrics)
47.61 # github.com/containerd/containerd/runtime/v2/shim
47.61 vendor/github.com/containerd/containerd/runtime/v2/shim/publisher.go:39:12: undefined: v1.Envelope
47.61 vendor/github.com/containerd/containerd/runtime/v2/shim/publisher.go:118:11: undefined: v1.Envelope
59.83 + rm -f /go/src/github.com/docker/docker/go.mod

@thaJeztah
Copy link
Member

So for the module to be usable for 1.x, (1.7), it looks like some changes are needed in the 1.7 code 🤔

@dmcgowan
Copy link
Member Author

We can bring in those changes to make it compatible, testing with #10278

This PR doesn't depend on that though and can be considered on its own.

@dmcgowan dmcgowan marked this pull request as ready for review May 28, 2024 22:46
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/go.mod Show resolved Hide resolved
@mxpv mxpv added this pull request to the merge queue May 29, 2024
Merged via the queue into containerd:main with commit a5ba3b7 May 29, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants