-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api minimum Go version to 1.21 #10276
Conversation
A higher go build version is not required for the API Signed-off-by: Derek McGowan <derek@mcg.dev>
Skipping CI for Draft Pull Request. |
So, it does not immediately refuse it now, but it looks like API 1.8 is not backward compatible from a Go perspective. It looks like some parts were removed that the 1.7 code expects (perhaps moved elsewhere?)
|
So for the module to be usable for 1.x, (1.7), it looks like some changes are needed in the 1.7 code 🤔 |
We can bring in those changes to make it compatible, testing with #10278 This PR doesn't depend on that though and can be considered on its own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A higher go build version is not required for the API and this will help some downstream projects test the change which are currently blocked on 1.22 upgrade.