Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type alias for event Envelope #10279

Merged
merged 1 commit into from
May 29, 2024
Merged

Add type alias for event Envelope #10279

merged 1 commit into from
May 29, 2024

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented May 28, 2024 •
edited

To maintain compatibility with 1.7 API. In 1.7 the types are different so can't be aliased.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

thaJeztah
thaJeztah reviewed May 29, 2024
View reviewed changes
api/services/events/v1/doc.go Outdated Show resolved Hide resolved
api/services/ttrpc/events/v1/doc.go Outdated Show resolved Hide resolved
@dmcgowan
Add type alias for event Envelope
3e71cca 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan marked this pull request as ready for review May 29, 2024 18:25
thaJeztah
thaJeztah approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv added this pull request to the merge queue May 29, 2024
Merged via the queue into containerd:main with commit 080d35b May 29, 2024
42 checks passed
@thaJeztah thaJeztah mentioned this pull request Jun 3, 2024
Merged
@dmcgowan dmcgowan mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@mxpv mxpv mxpv approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
impact/deprecation size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmcgowan @k8s-ci-robot @dims @mxpv @thaJeztah