Support multiple uid/gid mappings [1/2] #10307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry118
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
henry118
changed the title
Kern--
reviewed
Jun 7, 2024
henry118
force-pushed
the
uidmap
branch
2 times, most recently
from
2e0a5a2
to
ac777c9
Compare
henry118
force-pushed
the
uidmap
branch
3 times, most recently
from
26107e7
to
4e7f0ea
Compare
|
/test pull-containerd-node-e2e |
|
I'm adding to 2.0 milestone; @containerd/maintainers let me know if anyone thinks it should not be in 2.0 |
estesp
reviewed
Jun 28, 2024
cmd/ctr/commands/run/run_unix.go
Outdated
| @@ -45,11 +47,11 @@ import ( | |||
| ) | |||
|
|
|||
| var platformRunFlags = []cli.Flag{ | |||
| &cli.StringFlag{ | |||
| &cli.StringSliceFlag{ | |||
| Name: "uidmap", | |||
| Usage: "Run inside a user namespace with the specified UID mapping range; specified with the format `container-uid:host-uid:length`", | |||
There was a problem hiding this comment.
I think the usage string (for this and gidmap) needs to reflect that it is now a slice/list of maps; at least the first clause should end with mapping range(s); could also add at the end a new clause: ", separate multiple mappings with a comma"
There was a problem hiding this comment.
After this change, the help message for this option becomes the following.
--uidmap container-uid:host-uid:length [ --uidmap container-uid:host-uid:length ] Run inside a user namespace with the specified UID mapping range; specified with the format container-uid:host-uid:length
I think the additional [] will indicate the option is a slice. But I think updating the "mapping range" to "mapping ranges" was a good call out. I will make the update in the next revision.
Signed-off-by: Henry Wang <henwang@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance user namespace implementation to support multi-entry uid/gid mappings.
This is 1st patch (out of 2) that supports multiple entries of uid/gid configurations. This patch focuses on the "slow" path that requires
chownon every file in the root FS. uidmapped mounts implementation will be covered in a separate PR.This implementation has changes in the following area:
IdentityMappingimplementation fromidtoolspackage in Moby.--uidmap, --gidmapoptions inctr runcommand.An sample command to run a container with remapped
foouser:I hope the implementation makes sense and I'm looking forward to your feedback :)