Runtime name printed correctly for containers listing. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime is not printed while container listing due to typo introduced in containerd#935. This fixes the Typo. Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
=======================================
Coverage 54.51% 54.51%
=======================================
Files 16 16
Lines 1229 1229
=======================================
Hits 670 670
Misses 386 386
Partials 173 173Continue to review full report at Codecov.
|
|
LGTM |
ianlewis
pushed a commit
to ianlewis/containerd
that referenced
this pull request
Dec 8, 2020
…ivileged Add test for filtering container create masks when privileged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime is not printed while container listing due to typo introduced
in #935.
This fixes the Typo.
Signed-off-by: Kunal Kushwaha kushwaha_kunal_v7@lab.ntt.co.jp