Add WithProcessKill DeleteOpt #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaventure
reviewed
Aug 7, 2017
| t.Error(err) | ||
| return | ||
| } | ||
| if _, err := task.Delete(ctx); err == nil { |
There was a problem hiding this comment.
i'm testing before and after with the option
There was a problem hiding this comment.
Ah, read the condition wrong, my bad 👍
crosbymichael
force-pushed
the
task-force
branch
from
d6abb27
to
bbbad93
Compare
|
LGTM. Thanks! |
|
LGTM |
crosbymichael
force-pushed
the
task-force
branch
from
bbbad93
to
33eaab9
Compare
Add an option that allows users for force kill and delete a process/task when calling `Delete` Fixes containerd#1274 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
task-force
branch
from
33eaab9
to
d8c075a
Compare
|
Fixed the checkpoint tests that were broken after this change. |
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 33.96% 33.96%
=======================================
Files 24 24
Lines 2723 2723
=======================================
Hits 925 925
Misses 1598 1598
Partials 200 200Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option that allows users for force kill and delete a process/task
when calling
DeleteFixes #1274
Signed-off-by: Michael Crosby crosbymichael@gmail.com