Add KillOpts for killing all processes #1434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
======================================
Coverage 40.8% 40.8%
======================================
Files 23 23
Lines 2924 2924
======================================
Hits 1193 1193
Misses 1453 1453
Partials 278 278Continue to review full report at Codecov.
|
task_opts.go
Outdated
| All bool | ||
| } | ||
|
|
||
| type KillOpts func(context.Context, Process, *KillInfo) error |
There was a problem hiding this comment.
nit: Could the options just take in the KillRequest type?
There was a problem hiding this comment.
No, we have been going away from exposing the protos in the client interfaces
|
ping @Random-Liu , can you take a look at this and see if it's what you had in mind? |
| @@ -51,3 +51,15 @@ func WithProcessKill(ctx context.Context, p Process) error { | |||
| <-s | |||
| return nil | |||
| } | |||
|
|
|||
| type KillInfo struct { | |||
| // All kills all processes inside the task | |||
There was a problem hiding this comment.
Probably comment that this only works for task. IIUC, exec.Kill will just ignore this field inside the shim.
|
LGTM with a nit. @crosbymichael Thanks for the quick fix! |
Fixes containerd#1431 This adds KillOpts so that a client can specify when they want to kill a single process or all the processes inside a container. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
kill-all
branch
from
ccf1f5a
to
ed6b8fb
Compare
Fixes #1431
This adds KillOpts so that a client can specify when they want to kill a
single process or all the processes inside a container.
Signed-off-by: Michael Crosby crosbymichael@gmail.com