New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place containerd inside cgroup #1443
Conversation
This adds a config option to place the `containerd` daemon process into a cgroup so that proper resource usage and accounting can be applied. It defaults to not being place inside a cgroup and will create a new cgroup if the `path` does not exist in the config or join an existing `path` if it already exists. ```toml [cgroup] path = "/containerd" ``` Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
This should help with the container manager for making sure containerd and its shims are placed inside a cgroup together. ref: containerd/cri#62 |
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
======================================
Coverage 40.8% 40.8%
======================================
Files 23 23
Lines 2924 2924
======================================
Hits 1193 1193
Misses 1453 1453
Partials 278 278 Continue to review full report at Codecov.
|
@crosbymichael This is cooooool! I thought we had to do it ourselves. :) |
I discussed this with @yujuhong. We'll do the same in cri-containerd. For now it will be users' responsibility to properly configure the node, to make sure containerd, cri-containerd are in runtime cgroup; and tell kubelet where the cgroup is. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…support Build runc with selinux support
This adds a config option to place the
containerd
daemon process intoa cgroup so that proper resource usage and accounting can be applied.
It defaults to not being place inside a cgroup and will create a new
cgroup if the
path
does not exist in the config or join an existingpath
if it already exists.Signed-off-by: Michael Crosby crosbymichael@gmail.com