Trap close error on shutdown #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
=======================================
Coverage 40.82% 40.82%
=======================================
Files 23 23
Lines 2920 2920
=======================================
Hits 1192 1192
Misses 1451 1451
Partials 277 277Continue to review full report at Codecov.
|
estesp
approved these changes
Sep 13, 2017
There was a problem hiding this comment.
LGTM
One small nit..given the change from GracefulStop to Stop we might want to change the method comment above it as Stop sounds like it cancels any open gRPC connections (unlike GracefulStop which according to its GoDoc: blocks until all the pending RPCs are finished)
crosbymichael
force-pushed
the
trap-err
branch
from
957ce3d
to
8192544
Compare
Fixes containerd#1499 This traps any Accept() errors on server shutdown so that it exits cleanly. It also changes gracefulstop to stop on the grpc server as the daemon will not shutdown if there are connected clients. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
trap-err
branch
from
8192544
to
03b43ac
Compare
|
@estesp updated the comment |
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
…-cgroups-controller Tolerate missing HugeTLB cgroups controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1499
This traps any Accept() errors on server shutdown so that it exits
cleanly.
It also changes gracefulstop to stop on the grpc server as the daemon
will not shutdown if there are connected clients.
Signed-off-by: Michael Crosby crosbymichael@gmail.com