Close epoller on task delete #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
=======================================
Coverage 42.61% 42.61%
=======================================
Files 24 24
Lines 3318 3318
=======================================
Hits 1414 1414
Misses 1581 1581
Partials 323 323Continue to review full report at Codecov.
|
estesp
approved these changes
Sep 20, 2017
There was a problem hiding this comment.
LGTM
I assume the Azure vendor removals are reasonable as appveyor ran and passed; I assume could have been a newer version of vndr or console update depended on less content in the Azure win-term library?
EDIT: nvm; I see the drop of import in the console update: https://github.com/containerd/containerd/pull/1529/files#diff-45aa7979a29beaa0a34768de2c01bc90L7
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
…ugepages allow disabling hugepages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the epoller and bumps the console dep to allow it to be closed.