windows: Use stdtime for hcsshimtypes.ProcessDetails.CreatedAt #1649
Conversation
mlaventure
force-pushed
the
win-procdetaisl-use-stdtime
branch
from
caf4829
to
f5be894
Compare
|
rebase? |
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
win-procdetaisl-use-stdtime
branch
from
f5be894
to
e7ea7b5
Compare
|
rebased |
|
rebased! |
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
=======================================
Coverage 49.06% 49.06%
=======================================
Files 27 27
Lines 4080 4080
=======================================
Hits 2002 2002
Misses 1663 1663
Partials 415 415Continue to review full report at Codecov.
|
|
LGTM |
| @@ -16,7 +16,7 @@ message CreateOptions { | |||
| // ProcessDetails is made of the same fields as found in hcsshim.ProcessListItem | |||
| message ProcessDetails { | |||
| string image_name = 1; | |||
| google.protobuf.Timestamp created_at = 2; | |||
| google.protobuf.Timestamp created_at = 2 [(gogoproto.stdtime) = true, (gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
how did you figure out that this needed to be added?
There was a problem hiding this comment.
and is the conversion from ProcessListItem type time.Time to CreatedAt type google.protobuf.Timestamp now done for you?
There was a problem hiding this comment.
That's what we use in the other proto files, it indeed permits us not to deal with the google.protobuf.Timestamp conversion as it is done by the generated code now.
One of the advantages of gogoproto. I think we have @stevvooe to thank for using these options originally.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
--
/cc @jessvalarezo