[release/1.0] cherrypick Fix NPE in dialer #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Yi <denverdino@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2034 +/- ##
============================================
Coverage 50.59% 50.59%
============================================
Files 81 81
Lines 7165 7165
============================================
Hits 3625 3625
Misses 2847 2847
Partials 693 693
Continue to review full report at Codecov.
|
|
LGTM |
1 similar comment
|
LGTM |
|
Not sure why Windows CI didn't run; do I need to re-push to kick it? |
|
@estesp I don't think it runs on this branch. We'll have to fix that for 1.1. |
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2022
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com
Signed-off-by: Li Yi denverdino@gmail.com