Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Windows servicing containers #2147

Merged
merged 1 commit into from Feb 21, 2018

Conversation

darstahl
Copy link
Contributor

This removes the Windows Servicing container infrastructure. This is being removed from the platform, and was never used in production.

See microsoft/hcsshim#158

Signed-off-by: Darren Stahl darst@microsoft.com

Signed-off-by: Darren Stahl <darst@microsoft.com>
@codecov-io
Copy link

Codecov Report

Merging #2147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2147   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files          80       80           
  Lines        8726     8726           
=======================================
  Hits         3973     3973           
  Misses       4107     4107           
  Partials      646      646
Flag Coverage Δ
#linux 50.24% <ø> (ø) ⬆️
#windows 41.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1291671...243467a. Read the comment docs.

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if I had known, I wouldn't have bothered haha :)

@mlaventure mlaventure merged commit 916cdb4 into containerd:master Feb 21, 2018
@crosbymichael
Copy link
Member

LGTM

@darstahl darstahl deleted the RemoveServicing branch February 21, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants