Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.0] archive: fix logic for skipping mknod when running in userns #2179

Merged
merged 1 commit into from Mar 2, 2018

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

cherry-pick #2163

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@codecov-io
Copy link

Codecov Report

Merging #2179 into release/1.0 will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.0    #2179      +/-   ##
===============================================
+ Coverage        50.56%   50.57%   +0.01%     
===============================================
  Files               81       81              
  Lines             7169     7171       +2     
===============================================
+ Hits              3625     3627       +2     
  Misses            2849     2849              
  Partials           695      695
Flag Coverage Δ
#linux 50.57% <50%> (+0.01%) ⬆️
Impacted Files Coverage Δ
archive/tar_unix.go 52.38% <50%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd0439...a3372da. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit d18de62 into containerd:release/1.0 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants