Improve WithUser comments and code style. #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Liu <lantaol@google.com>
mlaventure
approved these changes
Mar 30, 2018
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
=======================================
Coverage 41.13% 41.13%
=======================================
Files 66 66
Lines 7758 7758
=======================================
Hits 3191 3191
Misses 4063 4063
Partials 504 504
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address comments from #2257.
Signed-off-by: Lantao Liu lantaol@google.com